Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #45

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Small fixes #45

merged 3 commits into from
Jan 22, 2024

Conversation

sumpfralle
Copy link
Contributor

While preparing some new test code a few minor details were fixed.

Previously no timeout was used at all.
This surely lead to some usability issues in case of temporary network
problems.
Previously during the extension setup a connection was attempted once
and the success state of this attempt was memorized.
In later search queries a stored failure caused the backend query to be
skipped.

This lead to two problems:
* Not all requests took the initial connection test result into account
  (i.e. some queries were skipped and some were not).
* The initial connection test result was not updated during the life
  time of the extension (i.e. until the next restart of Mopidy).
  Thus, a broken connection could never recover.
The listing was broken since commit 1e9ca37.
Now we enforce the string conversion for browse item names again.
@sumpfralle sumpfralle merged commit bce4c07 into mopidy:main Jan 22, 2024
6 of 7 checks passed
@sumpfralle sumpfralle deleted the small-fixes branch January 22, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant